Skip to content

Conversation

@marianosimone
Copy link
Contributor

As proposed by @ko1 in #750, make INFO the default level, so we can move down some messages like:

DEBUGGER:  BP - Line  /<redacted>.rb:<line> (call) is activated.

At the same time, there seem to be a lot of current logs that are more suited for the DEBUG level than INFO, so I'm moving those down to not make the new default more noisy.

@ko1
Copy link
Collaborator

ko1 commented Sep 16, 2022

Thank you for the patch.
Viewing the changes, I want additional info command :p

    1. Convenience information
    • enabling breakpoint
    • forking process
    1. Less-convenience information (but sometimes it is useful)
    • loading a ruby file
    1. debugger Internal events

I agree 1 and 3 is INFO and DEBUG. Not sure for 2. Your patch makes 2 as DEBUG (and I agree almost it is enough).
hmm.

The current design

  • WARN - for 1
  • INFO - for 2
  • DEBUG - for 3

is better? Let me take a time for consideration.
Another tools/debuggers examples are also welecome.

@marianosimone
Copy link
Contributor Author

marianosimone commented Sep 16, 2022

I think ERROR, WARN, INFO and DEBUG are pretty standard in terms of logging levels, and they roughly match with my patch here. I believe it would be weird to add a new level in between them.

Feel free to edit this PR as you see fit to match your logging philosophy, though :)

@marianosimone marianosimone closed this by deleting the head repository Oct 25, 2022
@marianosimone marianosimone reopened this Oct 25, 2022
@ko1
Copy link
Collaborator

ko1 commented Nov 22, 2022

fix with #823

@ko1 ko1 closed this Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants