Skip to content

Support BasicObject in Chrome debugging #773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 25, 2022
Merged

Support BasicObject in Chrome debugging #773

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions lib/debug/server_cdp.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -872,8 +872,8 @@ def process_cdp args
result = b.local_variable_get(expr)
rescue NameError
# try to check method
if b.receiver.respond_to? expr, include_all: true
result = b.receiver.method(expr)
if M_RESPOND_TO_P.bind_call(b.receiver, expr, include_all: true)
result = M_METHOD.bind_call(b.receiver, expr)
else
message = "Error: Can not evaluate: #{expr.inspect}"
end
Expand Down Expand Up @@ -987,10 +987,10 @@ def process_cdp args
]
end

result += obj.instance_variables.map{|iv|
variable(iv, obj.instance_variable_get(iv))
result += M_INSTANCE_VARIABLES.bind_call(obj).map{|iv|
variable(iv, M_INSTANCE_VARIABLE_GET.bind_call(obj, iv))
}
prop += [internalProperty('#class', obj.class)]
prop += [internalProperty('#class', M_CLASS.bind_call(obj))]
end
event! :cdp_result, :properties, req, result: result, internalProperties: prop
end
Expand Down Expand Up @@ -1045,7 +1045,7 @@ def propertyDescriptor_ name, obj, type, description: nil, subtype: nil
v = prop[:value]
v.delete :value
v[:subtype] = subtype if subtype
v[:className] = obj.class
v[:className] = (klass = M_CLASS.bind_call(obj)).name || klass.to_s
end
prop
end
Expand Down