restart all threads on eval #947
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a thread keeps a lock, and REPL runs a code which needs the lock, other threads should make a progress to release the lock. fix #877
|
This is amazing! Thank you for the fix 🙏 |
st0012
added a commit
to Shopify/debug
that referenced
this pull request
Mar 29, 2023
This makes sure DAP evaluation request also doesn't hang. See ruby#947 for the original console implementation.
This was referenced Mar 29, 2023
Merged
st0012
added a commit
to Shopify/debug
that referenced
this pull request
Mar 30, 2023
This makes sure DAP evaluation request also doesn't hang. See ruby#947 for the original console implementation.
st0012
added a commit
to Shopify/debug
that referenced
this pull request
Mar 31, 2023
This makes sure DAP evaluation request also doesn't hang. See ruby#947 for the original console implementation.
ko1
pushed a commit
that referenced
this pull request
Apr 1, 2023
This makes sure DAP evaluation request also doesn't hang. See #947 for the original console implementation.
st0012
added a commit
to Shopify/debug
that referenced
this pull request
Apr 3, 2023
This makes sure DAP evaluation request also doesn't hang. See ruby#947 for the original console implementation.
st0012
added a commit
to Shopify/debug
that referenced
this pull request
Apr 3, 2023
This makes sure DAP evaluation request also doesn't hang. See ruby#947 for the original console implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a thread keeps a lock, and REPL runs a code which needs the
lock, other threads should make a progress to release the lock.
fix #877