chore: add logs for events coming with an incorrect source and sourceRunId #6309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihir20
force-pushed
the
mihir/pipe-2364
branch
from
4876ed2 to
067516d
Compare
atzoum
reviewed
Sep 4, 2025
| BotAction: msg.Properties.BotAction, | ||
| } | ||
|
|
||
| if msg.Properties.SourceJobRunID != "" && src.SourceDefinition.Category == "" { |
There was a problem hiding this comment.
question: what are all possible values for category?
There was a problem hiding this comment.
these are all the possible values for categories:
- singer-protocol
- cloud
- warehouse
- webhook
- "" -- empty string is for event stream destinations.
mihir20
force-pushed
the
mihir/pipe-2364
branch
from
067516d to
36e327e
Compare
cisse21
approved these changes
Sep 9, 2025
atzoum
approved these changes
Sep 9, 2025
This was referenced Sep 15, 2025
Merged
satishrudderstack
pushed a commit
that referenced
this pull request
Sep 15, 2025
🤖 I have created a release *beep* *boop* --- ## [1.59.0-rc.1](v1.58.0...v1.59.0-rc.1) (2025-09-15) ### Features * **router:** add request latency and count metrics for router deliveries ([#6288](#6288)) ([c8dd8ef](c8dd8ef)) ### Bug Fixes * avoid running migrations for notifier from slaves ([#6303](#6303)) ([761eb46](761eb46)) * **batchrouter:** support configurable column ordering in CSVs in sftp ([#6342](#6342)) ([652215b](652215b)) * populate table level schemas createdAt updatedAt ([#6344](#6344)) ([a76a509](a76a509)) * remove unwanted table level schemas ([#6296](#6296)) ([761eb46](761eb46)) * **router:** kinesis rate exceeded errors are being aborted with http 400 ([#6329](#6329)) ([f739d7f](f739d7f)) * update ID regex to include underscores in error cleanup ([#6315](#6315)) ([bc1a751](bc1a751)) ### Miscellaneous * add logs for events coming with an incorrect source and sourceRunId ([#6309](#6309)) ([17afa60](17afa60)) * add readme for OAuth module ([#6335](#6335)) ([3c9f251](3c9f251)) * bump go-kit ([#6321](#6321)) ([87499e0](87499e0)) * bump mvdan.cc/gofumpt to v0.9.1 ([#6328](#6328)) ([cf9f653](cf9f653)) * capture stats for failed transformer client requests ([#6300](#6300)) ([e10d5c1](e10d5c1)) * clean up legacy MTU logic ([#6314](#6314)) ([a2e753d](a2e753d)) * clean up logs to trace double-encoded HLL value issue ([#6310](#6310)) ([c707aea](c707aea)) * drop unused services/oauth v1 and minor v2 tidy-ups ([#6275](#6275)) ([c1b84c1](c1b84c1)) * improve googlesheets oauth flow and error handling ([#6340](#6340)) ([738d420](738d420)) * optimize dtransform payloads and have compaction always enabled ([#6331](#6331)) ([63af856](63af856)) * remove proc_error jobsdb ([#6287](#6287)) ([5b92665](5b92665)) * renaming mirroring modes ([#6325](#6325)) ([84687fb](84687fb)) * **router:** ignore throttling costs in pickup throttler ([#6316](#6316)) ([af85b92](af85b92)) * sync release v1.58.0 to main branch ([#6294](#6294)) ([565630e](565630e)) * unify adaptive and static throttling configuration ([#6327](#6327)) ([077b0fb](077b0fb)) * update rudderlabs/build-scan-push-action to 1.7.0 ([#6320](#6320)) ([edb02d3](edb02d3)) * updating keydb client ([#6301](#6301)) ([0f9e3ec](0f9e3ec)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
satishrudderstack
pushed a commit
that referenced
this pull request
Sep 16, 2025
🤖 I have created a release *beep* *boop* --- ## [1.59.0](v1.58.0...v1.59.0) (2025-09-15) ### Features * **router:** add request latency and count metrics for router deliveries ([#6288](#6288)) ([c8dd8ef](c8dd8ef)) ### Bug Fixes * avoid running migrations for notifier from slaves ([#6303](#6303)) ([761eb46](761eb46)) * **batchrouter:** support configurable column ordering in CSVs in sftp ([#6342](#6342)) ([652215b](652215b)) * populate table level schemas createdAt updatedAt ([#6344](#6344)) ([a76a509](a76a509)) * remove unwanted table level schemas ([#6296](#6296)) ([761eb46](761eb46)) * **router:** kinesis rate exceeded errors are being aborted with http 400 ([#6329](#6329)) ([f739d7f](f739d7f)) * update ID regex to include underscores in error cleanup ([#6315](#6315)) ([bc1a751](bc1a751)) ### Miscellaneous * add logs for events coming with an incorrect source and sourceRunId ([#6309](#6309)) ([17afa60](17afa60)) * add readme for OAuth module ([#6335](#6335)) ([3c9f251](3c9f251)) * bump go-kit ([#6321](#6321)) ([87499e0](87499e0)) * bump mvdan.cc/gofumpt to v0.9.1 ([#6328](#6328)) ([cf9f653](cf9f653)) * capture stats for failed transformer client requests ([#6300](#6300)) ([e10d5c1](e10d5c1)) * clean up legacy MTU logic ([#6314](#6314)) ([a2e753d](a2e753d)) * clean up logs to trace double-encoded HLL value issue ([#6310](#6310)) ([c707aea](c707aea)) * drop unused services/oauth v1 and minor v2 tidy-ups ([#6275](#6275)) ([c1b84c1](c1b84c1)) * improve googlesheets oauth flow and error handling ([#6340](#6340)) ([738d420](738d420)) * optimize dtransform payloads and have compaction always enabled ([#6331](#6331)) ([63af856](63af856)) * remove proc_error jobsdb ([#6287](#6287)) ([5b92665](5b92665)) * renaming mirroring modes ([#6325](#6325)) ([84687fb](84687fb)) * **router:** ignore throttling costs in pickup throttler ([#6316](#6316)) ([af85b92](af85b92)) * sync release v1.58.0 to main branch ([#6294](#6294)) ([565630e](565630e)) * unify adaptive and static throttling configuration ([#6327](#6327)) ([077b0fb](077b0fb)) * update rudderlabs/build-scan-push-action to 1.7.0 ([#6320](#6320)) ([edb02d3](edb02d3)) * updating keydb client ([#6301](#6301)) ([0f9e3ec](0f9e3ec)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add logs for events coming with an incorrect source and sourceRunId
Linear Ticket
pipe-2364
Security