-
Notifications
You must be signed in to change notification settings - Fork 650
Add backward seek-based pagination support for the search endpoint #10793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
eth3lbert
wants to merge
13
commits into
rust-lang:main
Choose a base branch
from
eth3lbert:seek-pagination-backward
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
f697740
controllers/helpers/pagination: Rename `Seek::after()` to `Seek::deco…
eth3lbert d1dc40b
controllers/helpers/pagination: Add an option to enable seeking backward
eth3lbert 77eb338
controllers/helpers/pagination: Add `Page::SeekBackward()` variant
eth3lbert 84f9152
controllers/helpers/pagination: Consider empty `RawSeekPayload` as valid
eth3lbert 624ab10
controllers/krate/search: Build query ordering based on direction
eth3lbert 0e21380
controllers/krate/search: Build query filter for seek-based pagination
eth3lbert 6bb6793
controllers/helpers/pagination: Add `PaginationOptions::is_backward()…
eth3lbert 7b91ca3
controllers/helpers/pagination: Add `PaginationOptions::is_explicit()…
eth3lbert 454f35d
controllers/helpers/pagination: Handle null `next_page` for seek-base…
eth3lbert 193a57d
controllers/helpers/pagination: Maintain consistent ordering from pag…
eth3lbert 847e8bc
controllers/helpers/pagination: Generate `prev_page` for seek-based p…
eth3lbert 3f142f8
controllers/krate/search: Enable seeking backward for search
eth3lbert 44d5e67
controllers/helpers/pagination: Update the `seek` parameter descriptions
eth3lbert File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
controllers/helpers/pagination: Generate
prev_page
for seek-based p…
…agination
- Loading branch information
commit 847e8bce0898de9c2850e9c120b595dc6065402b
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is currently only tested with a page size of 1. It would be better to expand the tests to include varying page sizes.