Improve parsing error for static and const
#20805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example --- ```rust static C<i32>: u32 = 0; ``` -> ```diff -error 8: missing type for `const` or `static` +error 8: `static` may not have generic parameters ``` --- ```rust const C = 0; ``` -> ```diff -error 7: missing type for `const` or `static` +error 7: missing type for `const` ``` --- ```rust static C = 0; ``` -> ```diff -error 8: missing type for `const` or `static` +error 8: missing type for `static` ```
rustbot
added
the
S-waiting-on-review
ChayimFriedman2
approved these changes
Oct 8, 2025
| // } | ||
| generic_params::opt_generic_param_list(p); | ||
| } else if p.at(T![<]) { | ||
| p.error("`static` may not have generic parameters"); |
There was a problem hiding this comment.
I think it's preferable to eat generic params here, or even better, call opt_generic_params() unconditionally, and just err before for statics. This will also allow us to simplify the next if.
There was a problem hiding this comment.
Should the AST of a static item contain GENERIC_PARAM_LIST?
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example
->
->
->