Fix empty closure completion analysis #20811
Open
+20
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example
---
```rust
fn foo() {
bar(|| $0);
}
fn bar(f: impl FnOnce() -> u32) {}
```
**Before this PR**:
```
ty: impl FnOnce() -> u32, name: ?
```
**After this PR**:
```
ty: u32, name: ?
```
rustbot
added
the
S-waiting-on-review
| .unwrap_or((None, None)) | ||
| }, | ||
| ast::ParamList(_) => (None, None), | ||
| ast::ParamList(it) => { |
There was a problem hiding this comment.
Why is it inside a ParamList? Couldn't this degrade completions for some other cases?
There was a problem hiding this comment.
Why is it inside a
ParamList?
When completing || $0, the token is | and token.parent() is the ParamList
Couldn't this degrade completions for some other cases?
The difference should only be when ParamList is used as a closure parameter, because .and_then(ast::ClosureExpr::cast)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example
Before this PR:
After this PR: