Add manual_is_ascii_check lint

[koka831]

Addresses #9290

This PR adds new lint manual_is_ascii_check, which detects comparison with ascii ranges using matches! macros.

As I mentioned as following in the Issue;

Yes, that's true. we'll start small and then grow it.
So I'll try to handle matches! macro with single range as suggested above.

However during writing first version, I was thinking that the changes to support alphabetic and digits will be small patch, so I made a single PR in hope review cost can be reduced.

changelog: add new lint [manual_is_ascii_check]

r? @xFrednet

[xFrednet]

However during writing first version, I was thinking that the changes to support alphabetic and digits will be small patch, so I made a single PR in hope review cost can be reduced.

That is totally fine, my comment in the issue was more related to cases like:

assert(matches!(c, 'a'..='z') || matches!(c, 'A'..='Z'))

Which would require more effort with probably little benefit. Adding all is_ascii check at once sounds good to me :)

[xFrednet]

The implementation and created suggestions are really solid. Awesome work! I've left some small comments, but all of them should be simple to fix.

[koka831]

@xFrednet Thank you for review, I learned a lot!
review me again, please:)

[xFrednet]

Excellent, this implementation looks really solid to me. The test covers all cases I can think of. Thank you very much!

Before we merge, could you squash the update commits into one? You're welcome to reach out, if you need any help with the squashing.

[koka831]

squashed, and confirmed it won't change during the commit. https://github.com/rust-lang/rust-clippy/compare/0b0e0ef191994360dc647dd8fa6f3a7967a2621d..e4540ad65fa14ceebd5145ab771fe4918d170bf1

[xFrednet]

This version looks good to me, thank you for the update!

@bors r+

[bors]

📌 Commit e4540ad has been approved by xFrednet

It is now in the queue for this repository.

[bors]

⌛ Testing commit e4540ad with merge 4abe815...

[bors]

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: xFrednet
Pushing 4abe815 to master...