Skip to content

Performance issue for x test tidy #143032

Open
@chenyukang

Description

@chenyukang

x test tidy now cost about 19s on my machine (a M2 mac), I think it's a little bit too long for a trivial fix like #142871, when I discussed with @jieyouxu , he told me it only cost 9s on his dev environment(a WSL).

so I added some logs for cost time in each check in tidy test:
https://github.com/chenyukang/rust/blob/106a6d46375f7c13d4fee3511736193f59b74542/src/tools/tidy/src/main.rs#L87-L95

The result for each part is:

Image

I also meet the issue of #134648, but I do not know how to reproduce it now.

  • Do we need to run every tidy check phase for all kind of changes, I guess we may improve on this
  • Running them concurrently could speed things up x test tidy can be faster #141074
  • I haven't got the reason why it's much slower on my dev compared to @jieyouxu 's dev, maybe network speed ?

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-tidyArea: The tidy toolC-bugCategory: This is a bug.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions