Skip to content

Rollup of 7 pull requests #139881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Apr 15, 2025
Merged
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
250a1aa
make `AllTypes::print` return `impl fmt::Display`
yotamofek Mar 5, 2025
642995c
make `link_tooltip` return `impl fmt::Display`
yotamofek Mar 13, 2025
f7640d5
make `doc_impl_item` and `render_default_items` receive `impl fmt::Wr…
yotamofek Mar 13, 2025
8dd1cbb
lazify `render_assoc_items_inner`
yotamofek Mar 13, 2025
3df7882
Normalize ADT fields in find_tails_for_unsizing
compiler-errors Apr 14, 2025
1d75783
Remove safe remove
ChrisDenton Apr 14, 2025
f3847f0
Remove some "name isn't empty" assertions.
nnethercote Apr 8, 2025
2b43e66
Remove a `kw::Empty` usage in symbol mangling.
nnethercote Apr 8, 2025
c12b4aa
Use a dummy ident for a `lint_if_path_starts_with_module` call.
nnethercote Apr 9, 2025
c49b0bd
Use `rust-cache` to speed-up `citool` compilation
Kobzol Apr 14, 2025
73065b9
CI: rename MacOS runner
marcoieni Apr 15, 2025
043c5ff
Add warning comment to `Take::get_ref` and `Chain::get_ref`
joshtriplett Apr 15, 2025
ca0b7f4
Rollup merge of #138455 - yotamofek:pr/rustdoc/more-impl-display, r=G…
matthiaskrgr Apr 15, 2025
27f1f4d
Rollup merge of #139818 - compiler-errors:normalize-tails, r=oli-obk
matthiaskrgr Apr 15, 2025
b3e55a5
Rollup merge of #139819 - Kobzol:rust-cache, r=marcoieni
matthiaskrgr Apr 15, 2025
8bb01ff
Rollup merge of #139824 - ChrisDenton:non-canonical, r=petrochenkov
matthiaskrgr Apr 15, 2025
2144c94
Rollup merge of #139848 - nnethercote:kw-Empty-5, r=compiler-errors
matthiaskrgr Apr 15, 2025
2e363ce
Rollup merge of #139859 - marcoieni:rename-macos-runner, r=Kobzol
matthiaskrgr Apr 15, 2025
ebaef46
Rollup merge of #139877 - joshtriplett:take-care, r=dtolnay
matthiaskrgr Apr 15, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use a dummy ident for a lint_if_path_starts_with_module call.
This is pretty weird code. As the `HACK` comment indicates, we push the
empty ident here only to make the path longer, so certain checks to
occur within `lint_if_path_starts_with_module`. `dummy` is a better
choice because it explicitly communicates that the actual value doesn't
matter.
  • Loading branch information
nnethercote committed Apr 15, 2025
commit c12b4aade031e4ca4babb9cdfbe53f466ae76462
2 changes: 1 addition & 1 deletion compiler/rustc_resolve/src/imports.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1012,7 +1012,7 @@ impl<'ra, 'tcx> Resolver<'ra, 'tcx> {
// HACK(eddyb) `lint_if_path_starts_with_module` needs at least
// 2 segments, so the `resolve_path` above won't trigger it.
let mut full_path = import.module_path.clone();
full_path.push(Segment::from_ident(Ident::empty()));
full_path.push(Segment::from_ident(Ident::dummy()));
self.lint_if_path_starts_with_module(Some(finalize), &full_path, None);
}

Expand Down
Loading