Skip to content

Rollup of 10 pull requests #139895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 31 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
fc8df06
update submodules if the directory doesn't exist
WaffleLapkin Apr 14, 2025
1397dab
fix typo
WaffleLapkin Apr 14, 2025
6c441cc
canonicalize test build dir before normalizing it
WaffleLapkin Apr 14, 2025
2907ab5
Move `is_builder_target`, `is_system_llvm` and `is_rust_llvm` from `B…
Kobzol Apr 15, 2025
3c01dfe
Rename `is_builder_target` to `is_host_target`
Kobzol Apr 15, 2025
689b4c9
Disable combining LLD with external llvm-config
Kobzol Apr 15, 2025
502b630
tidy: don't crush on non-existent submodules
WaffleLapkin Apr 15, 2025
52f4b16
use helper function instead of writing rustfmt stamp by hand
WaffleLapkin Apr 15, 2025
dda4d7b
slightly correct comments and diagnostics about checking modifications
WaffleLapkin Apr 15, 2025
8934ac5
add a comment for code that isn't
WaffleLapkin Apr 15, 2025
8120950
Add test for issue 125668
reddevilmidzy Apr 15, 2025
11e5987
Don't compute name of associated item if it's an RPITIT
compiler-errors Apr 15, 2025
2020adb
Fix wrong suggestion for async gen block and add regression ui test f…
GuillaumeGomez Apr 15, 2025
90aec13
commit rustfmt stump in `x t tidy` even on `check`
WaffleLapkin Apr 15, 2025
89b4eba
normalize canonical and non-canonical paths in compiletest
WaffleLapkin Apr 15, 2025
f35c85f
Add unstable foo::bar extern command line arguments
eholk Apr 8, 2025
f3f53d2
Update books
rustbot Apr 15, 2025
ea1b230
Update Cargo.lock for rustbook
ehuss Apr 15, 2025
766cd3a
Remove support for `#[rustc_mir(borrowck_graphviz_format="gen_kill")]`.
nnethercote Apr 15, 2025
62882f3
Improve `borrowck_graphviz_*` documentation.
nnethercote Apr 15, 2025
6999305
Make CodeStat's type sizes a public field
blyxyas Apr 15, 2025
e849450
Rollup merge of #139647 - eholk:package-namespace, r=fmease
Zalathar Apr 16, 2025
6a10071
Rollup merge of #139823 - WaffleLapkin:bootpaper, r=jieyouxu
Zalathar Apr 16, 2025
8936612
Rollup merge of #139853 - Kobzol:lld-llvm-config, r=onur-ozkan
Zalathar Apr 16, 2025
2a560b6
Rollup merge of #139867 - WaffleLapkin:tidypaper, r=jieyouxu
Zalathar Apr 16, 2025
742ad62
Rollup merge of #139871 - GuillaumeGomez:async-gen-move, r=compiler-e…
Zalathar Apr 16, 2025
cd3d026
Rollup merge of #139876 - blyxyas:write_type_sizes, r=nnethercote
Zalathar Apr 16, 2025
1916a77
Rollup merge of #139880 - compiler-errors:rpitit-nameless, r=nnethercote
Zalathar Apr 16, 2025
ed73e1a
Rollup merge of #139884 - rustbot:docs-update, r=ehuss
Zalathar Apr 16, 2025
fd2f963
Rollup merge of #139886 - nnethercote:graphviz_borrowck, r=compiler-e…
Zalathar Apr 16, 2025
3ba13ab
Rollup merge of #139893 - reddevilmidzy:add-test, r=SparrowLii
Zalathar Apr 16, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
normalize canonical and non-canonical paths in compiletest
Apparently there are tests that print canonical paths *and* tests which
print non-canonical paths.

An example of the latter is `tests/ui/type_length_limit.rs`.
  • Loading branch information
WaffleLapkin committed Apr 15, 2025
commit 89b4eba49cc15e0a4e53f7816473201d12be5f4f
13 changes: 8 additions & 5 deletions src/tools/compiletest/src/runtest.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2375,13 +2375,16 @@ impl<'test> TestCx<'test> {
let rust_src_dir = rust_src_dir.read_link_utf8().unwrap_or(rust_src_dir.to_path_buf());
normalize_path(&rust_src_dir.join("library"), "$SRC_DIR_REAL");

// Canonicalize test build directory path.
// Without this some tests fail if build directory is a symlink.
let output_base_dir = self.output_base_dir().canonicalize_utf8().unwrap();

// eg.
// /home/user/rust/build/x86_64-unknown-linux-gnu/test/ui/<test_dir>/$name.$revision.$mode/
normalize_path(&output_base_dir, "$TEST_BUILD_DIR");
normalize_path(&self.output_base_dir(), "$TEST_BUILD_DIR");
// Same as above, but with a canonicalized path.
// This is required because some tests print canonical paths inside test build directory,
// so if the build directory is a symlink, normalization doesn't help.
//
// NOTE: There are also tests which print the non-canonical name, so we need both this and
// the above normalizations.
normalize_path(&self.output_base_dir().canonicalize_utf8().unwrap(), "$TEST_BUILD_DIR");
// eg. /home/user/rust/build
normalize_path(&self.config.build_root, "$BUILD_DIR");

Expand Down
Loading