Skip to content

add a test for issue rust-lang/rust#81317 #140632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

add a test for issue rust-lang/rust#81317 #140632

wants to merge 3 commits into from
+88 −0

Conversation

Skgland
Copy link
Contributor

@Skgland Skgland commented May 3, 2025

closes #81317

@rustbot
Copy link
Collaborator

rustbot commented May 3, 2025

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 3, 2025
@jieyouxu
Copy link
Member

jieyouxu commented May 4, 2025 •
edited
Loading

I'm slightly confused -- is this a regression test, or does it just try to make sure even further changes to this code pattern is observed in PR test diffs? (Because the MCVE still doesn't compile, since 1.49, due to inference changes.) Would be good clarifying that in the test comment.
r? @oli-obk

@rustbot rustbot assigned oli-obk and unassigned jieyouxu May 4, 2025
oli-obk
oli-obk reviewed May 5, 2025
View reviewed changes
tests/ui/type-inference/regression-issue-81317.rs
@@ -0,0 +1,40 @@
// Regression test for #81317: type can no longer be infered as of 1.49
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Document the reason this test is failing so someone reading or modifying it in the future doesn't have to reestablish context from scratch

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about now?

Copy link
Contributor

@oli-obk oli-obk May 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, that's great.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@oli-obk
Copy link
Contributor

oli-obk commented May 6, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 6, 2025

📌 Commit fb87845 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oli-obk oli-obk oli-obk left review comments

Assignees

@oli-obk oli-obk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Type can no longer be inferred in 1.49
6 participants
@Skgland @rustbot @jieyouxu @rust-log-analyzer @oli-obk @bors