collect all Fuchsia bindings into the fuchsia module
#140656
Open
+122
−282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Fuchsia bindings are currently spread out across multiple modules in `sys/pal/unix` leading to unnecessary duplication. This PR moves all of these definitions into `sys::pal::unix::fuchsia` and additionally: * deduplicates the definitions * makes the error names consistent * marks some extern functions as safe * removes unused items (there's no need to maintain these bindings if we're not going to use them) * removes the documentation for the definitions (contributors should always consult the platform documentation, duplicating that here is just an extra maintenance burden)
|
rustbot has assigned @workingjubilee. Use |
rustbot
added
O-unix
|
Hey friends of Fuchsia! This issue could use some guidance on how this should be |
|
I'm working on routing this internally to see who's best to review here. Erick is also out this week. |
|
Thanks! I will give the Fuchsia folks a bit to actually review this then. |
|
It looks like it's almost entirely just-moving-stuff tho'. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Fuchsia bindings are currently spread out across multiple modules in
sys/pal/unixleading to unnecessary duplication. This PR moves all of these definitions intosys::pal::unix::fuchsiaand additionally:zx_thread_selfandzx_clock_get_monotonicas safe extern functions@rustbot ping fuchsia