Parser: Recover error from named params while parse_path #140671
+108
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xizheyin <[email protected]>
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
compiler-errors
requested changes
May 5, 2025
|
@rustbot author |
rustbot
added
S-waiting-on-author
|
Reminder, once the PR becomes ready for a review, use |
xizheyin
commented
May 6, 2025
Comment on lines
-399
to
+413
| let (inputs, _) = match self.parse_paren_comma_seq(|p| p.parse_ty()) { | ||
| Ok(output) => output, | ||
| let dcx = self.dcx(); | ||
| let (inputs, _) = match self.parse_paren_comma_seq(|p| { | ||
| if p.is_named_param() { | ||
| let param = p.parse_param_general(|_| false, false); | ||
| if let Ok(ref param) = param { | ||
| dcx.emit_err(FnPathFoundNamedParams { | ||
| named_param_span: param.pat.span, | ||
| }); | ||
| } | ||
| param.map(|param| param.ty) | ||
| } else { | ||
| p.parse_ty() | ||
| } | ||
| }) { | ||
| Ok((output, trailing)) => (output, trailing), |
There was a problem hiding this comment.
Now, I used parse_param_general instead of the original parse_ty, and report errors when encountering a named paramter. It seems to make sense.
rustbot
added
S-waiting-on-review
xizheyin
changed the title
Fn, FnOnce, FnMut trait with named params
This comment has been minimized.
This comment has been minimized.
Signed-off-by: xizheyin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #140169
I added test to the first commit and the second added the code and changes to test.
r? @petrochenkov