Skip to content

Don't ignore compiler stderr in lib-defaults.rs #140681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Don't ignore compiler stderr in lib-defaults.rs #140681

wants to merge 1 commit into from
+17 −15

Conversation

jieyouxu
Copy link
Member

@jieyouxu jieyouxu commented May 5, 2025 •
edited
Loading

Closes #54222.

  • Don't ignore compiler stderr.
  • Document test intent.
  • Move under tests/ui/link-native-libs/ instead.

This was previously discussed on https://web.archive.org/web/20181028094402/https://botbot.me/mozilla/rust-tools/2017-02-21/?page=1.

try-job: armhf-gnu
try-job: test-various
try-job: x86_64-msvc-1
try-job: i686-msvc-1
try-job: x86_64-mingw-1
try-job: aarch64-apple
try-job: x86_64-apple-1

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 5, 2025
@jieyouxu
Copy link
Member Author

jieyouxu commented May 5, 2025

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request May 5, 2025
@bors
Auto merge of rust-lang#140681 - jieyouxu:test_helpers, r=<try>
c0d9dd6 
[WIP] Don't ignore compiler stderr in `lib-defaults.rs`

When does this fail?

try-job: armhf-gnu
try-job: test-various
try-job: x86_64-msvc-1
try-job: i686-msvc-1
try-job: x86_64-mingw-1
try-job: aarch64-apple
try-job: x86_64-apple-1
@bors
Copy link
Collaborator

bors commented May 5, 2025

⌛ Trying commit 91c4931 with merge c0d9dd6...

@bors
Copy link
Collaborator

bors commented May 5, 2025

☀️ Try build successful - checks-actions
Build commit: c0d9dd6 (c0d9dd64181e85036ee198375916d83768e0b55b)

@jieyouxu jieyouxu changed the title [WIP] Don't ignore compiler stderr in lib-defaults.rs Don't ignore compiler stderr in lib-defaults.rs May 5, 2025
@jieyouxu jieyouxu marked this pull request as ready for review May 5, 2025 21:58
@rustbot
Copy link
Collaborator

rustbot commented May 5, 2025

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@jieyouxu
tests: don't ignore compiler stderr in lib-defaults.rs
cbaa73b 
And also:

- Document test intent.
- Move under `link-native-libs/` instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@petrochenkov petrochenkov

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

run-pass/lib-defaults.rs warns of redundant linker flag
4 participants
@jieyouxu @bors @rustbot @petrochenkov