Improve dangerous_implicit_aurorefs diagnostic output
#140768
+253
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Not a good reviewer for this, maybe r? @RalfJung |
|
I'm not really an expert for lint implementations, and hardly use these HIR APIs. Let's see if this works |
RalfJung
reviewed
May 8, 2025
RalfJung
reviewed
May 8, 2025
Urgau
force-pushed
the
improv_autorefs-lint
branch
from
e4fac05 to
5e5cacd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR greatly improves the
dangerous_implicit_aurorefslint diagnostic output.Kind of related to #140721.
r? @jieyouxu (maybe)