Skip to content

Make associated type defaults closer to the spec #26728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 4, 2015
Merged

Make associated type defaults closer to the spec #26728

merged 2 commits into from
Jul 4, 2015

Conversation

arielb1
Copy link
Contributor

@arielb1 arielb1 commented Jul 1, 2015

r? @nrc

nrc
nrc reviewed Jul 3, 2015
View reviewed changes
src/librustc_typeck/check/mod.rs
if let Some(at) = overriden_associated_type {
span_note!(tcx.sess, at.span,
"an overriden associated type \
requires reimplementations of all trait-items");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This error message could be much more helpful - showing what caused the problem and what needs to be fixed. Happy to see that as follow-up rather than doing it now, but please file an issue and add a FIXME here.

@nrc
Copy link
Member

nrc commented Jul 3, 2015

Code looks good. I thought we were going to make this a warning at first? Is this not the breaking change we discussed on irc?

@arielb1 arielb1 force-pushed the assoc-maybe branch 4 times, most recently from 0d1c66e to 4f165c3 Compare July 3, 2015 23:18
@arielb1
Copy link
Contributor Author

arielb1 commented Jul 3, 2015

Updated.

@nrc
Copy link
Member

nrc commented Jul 4, 2015

@bors: r+

@bors
Copy link
Collaborator

bors commented Jul 4, 2015

📌 Commit 4f165c3 has been approved by nrc

@bors
Copy link
Collaborator

bors commented Jul 4, 2015

⌛ Testing commit 4f165c3 with merge 5e54df3...

@bors
Copy link
Collaborator

bors commented Jul 4, 2015

💔 Test failed - auto-win-gnu-64-opt

Ariel Ben-Yehuda added 2 commits July 4, 2015 14:08
Clean-up check_impl_items_against_trait
ace8670
require reimplementations of all items when a defaulted associated ty…
6b27005 
…pe is overriden

This is a
[breaking-change]
but it follows the RFC (not sure whether it will be accepted).
@arielb1
Copy link
Contributor Author

arielb1 commented Jul 4, 2015

@bors r=nrc

Reassigned error #

@bors
Copy link
Collaborator

bors commented Jul 4, 2015

📌 Commit 6b27005 has been approved by nrc

bors added a commit that referenced this pull request Jul 4, 2015
@bors
Auto merge of #26728 - arielb1:assoc-maybe, r=nrc
638ffec 
r? @nrc
@bors
Copy link
Collaborator

bors commented Jul 4, 2015

⌛ Testing commit 6b27005 with merge 638ffec...

@bors
Copy link
Collaborator

bors commented Jul 4, 2015

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt

@bors bors merged commit 6b27005 into rust-lang:master Jul 4, 2015
dgrunwald added a commit to dgrunwald/rust-cpython that referenced this pull request Jul 8, 2015
@dgrunwald
Adjust to breaking change rust-lang/rust#26728
04ea39d
SimonSapin added a commit to servo/rust-cssparser that referenced this pull request Jul 10, 2015
@SimonSapin
Remove some default associated types, so that default methods don’t h…
26a3c05 
…ave to be overridden.

Since rust-lang/rust#26728 , Servo would get build errors like:

    error: the following trait items need to be reimplemented as `AtRule` was overridden: `rule_without_block` [E0399]
        type AtRule = CSSRule;
        ^~~~~~~~~~~~~~~~~~~~~~
@brson brson added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jul 27, 2015
@brson brson mentioned this pull request Jul 28, 2015
Closed
@mitaa
Copy link
Contributor

mitaa commented Jul 29, 2015

Which RFC? Link?

@mitaa
Copy link
Contributor

mitaa commented Jul 29, 2015

I see.. the original rust-lang/rfcs#195.
Sorry for the noise.

@brson brson added the relnotes Marks issues that should be documented in the release notes of the next release. label Jul 29, 2015
@brson brson removed beta-nominated Nominated for backporting to the compiler in the beta channel. relnotes Marks issues that should be documented in the release notes of the next release. labels Jul 29, 2015
@brson
Copy link
Contributor

brson commented Jul 29, 2015

Not accepted for backporting to 1.2. After discussing with @nikomatsakis we're going to instead backport a patch to feature-gate default type parameters because there are still open questions about how they should work.

@aturon aturon mentioned this pull request Jul 29, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nrc nrc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@arielb1 @nrc @bors @mitaa @brson