-
Notifications
You must be signed in to change notification settings - Fork 13.5k
Document that heap allocations are not guaranteed to happen, even if explicitly performed in the code #79045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bors
merged 10 commits into
rust-lang:master
from
oli-obk:dont_rely_on_alloc_happening_for_soundness
Dec 26, 2020
Merged
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
a2f938a
Document that heap allocations are not guaranteed to happen, even if …
oli-obk 173892c
Note that there are other optimizations than the one showcased
oli-obk 3d1f676
Fix tidy
oli-obk dfca61a
Elaborate on side effects
oli-obk 58d62b8
Inform tidy about the reason for the ignored rust code
oli-obk fda4c8d
Update documentation to review comments
oli-obk 48c8ff5
Update library/core/src/alloc/global.rs
oli-obk 714feab
Update library/core/src/alloc/mod.rs
oli-obk fba17e3
Adjust markdown text to be more like the rendered text
oli-obk efcd8a9
DIrect invocations of `AllocRef::alloc` cannot get optimized away
oli-obk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix tidy
- Loading branch information
commit 3d1f6769066978946d381ca77e82e48b652bad65
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.