Skip to content

Remove PartialOrd/Ord impl for PlaceRef #96889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 12, 2022
Merged

Remove PartialOrd/Ord impl for PlaceRef #96889

merged 1 commit into from
May 12, 2022

Conversation

Aaron1011
Copy link
Member

This is a new attempt at #93315. It removes one usage
of the Ord impl for DefId, which should make it easier
to eventually remove that impl.

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label May 10, 2022
@rust-highfive
Copy link
Contributor

r? @compiler-errors

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 10, 2022
@bors
Copy link
Collaborator

bors commented May 11, 2022

☔ The latest upstream changes (presumably #96888) made this pull request unmergeable. Please resolve the merge conflicts.

@Aaron1011
Remove PartialOrd/Ord impl for PlaceRef
6b747aa 
This is a new attempt at rust-lang#93315. It removes one usage
of the `Ord` impl for `DefId`, which should make it easier
to eventually remove that impl.
@Aaron1011
Copy link
Member Author

@compiler-errors I've addressed your comments

@compiler-errors
Copy link
Member

cool, seems like those mir output changes disappeared in that case.

@bors r+

@bors
Copy link
Collaborator

bors commented May 11, 2022

📌 Commit 6b747aa has been approved by compiler-errors

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 11, 2022
@bors
Copy link
Collaborator

bors commented May 12, 2022

⌛ Testing commit 6b747aa with merge 3a08bd7...

@bors
Copy link
Collaborator

bors commented May 12, 2022

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 3a08bd7 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 12, 2022
@bors bors merged commit 3a08bd7 into rust-lang:master May 12, 2022
@rustbot rustbot added this to the 1.62.0 milestone May 12, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (3a08bd7): comparison url.

Summary:

  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: 😿 relevant regression found
Regressions 😿
(primary)		 Regressions 😿
(secondary)		 Improvements 🎉
(primary)		 Improvements 🎉
(secondary)		 All 😿 🎉
(primary)
count1 0 1 0 0 0
mean2 N/A 0.2% N/A N/A N/A
max N/A 0.2% N/A N/A N/A

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. number of relevant changes ↩

  2. the arithmetic mean of the percent change ↩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors left review comments

Assignees

@compiler-errors compiler-errors

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.62.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Aaron1011 @rust-highfive @bors @compiler-errors @rust-timer @rustbot