Skip to content

Inserted a local variable in volatile_load, to ensure reads don't move across blocks. #733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2025
Merged

Inserted a local variable in volatile_load, to ensure reads don't move across blocks. #733

merged 1 commit into from
Jul 9, 2025

Conversation

FractalFir
Copy link
Contributor

@FractalFir FractalFir commented Jul 8, 2025 •
edited by rustbot
Loading

Fixes #717

antoyo
antoyo reviewed Jul 8, 2025
View reviewed changes
@FractalFir FractalFir force-pushed the volatile_load_tmp branch from 13a8ef3 to f0450cf Compare July 9, 2025 18:45
@FractalFir
Copy link
Contributor Author

Ready for review.

@FractalFir FractalFir force-pushed the volatile_load_tmp branch from f0450cf to a736f34 Compare July 9, 2025 18:47
@FractalFir FractalFir force-pushed the volatile_load_tmp branch from a736f34 to 7e84472 Compare July 9, 2025 18:50
@antoyo antoyo merged commit 8a9af5f into rust-lang:master Jul 9, 2025
38 checks passed
@antoyo
Copy link
Contributor

antoyo commented Jul 9, 2025

Thanks a lot for this PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antoyo antoyo antoyo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Does volatile_load handle blocks correctly?
2 participants
@FractalFir @antoyo