Skip to content

thumbv7neon-unknown-linux-gnueabihf clippy fixes #1864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

hkBst
Copy link
Member

@hkBst hkBst commented Jul 11, 2025

This takes care of all clippy warnings for this target except for:

$ cargo clippy --target=thumbv7neon-unknown-linux-gnueabihf
warning: casting raw pointers to the same type and constness is unnecessary (`*const i8` -> `*const i8`)
     --> crates/core_arch/src/arm_shared/neon/generated.rs:16634:15
      |
16634 |     vld1_v8i8(ptr as *const i8, crate::mem::align_of::<i8>() as i32)
      |               ^^^^^^^^^^^^^^^^ help: try: `ptr`
      |
      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
      = note: `#[warn(clippy::unnecessary_cast)]` on by default

[snip]

warning: casting raw pointers to the same type and constness is unnecessary (`*const i8` -> `*const i8`)
     --> crates/core_arch/src/arm_shared/neon/generated.rs:26101:15
      |
26101 |     _vld4q_s8(a as *const i8, 1)
      |               ^^^^^^^^^^^^^^ help: try: `a`
      |
      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast

warning: `core_arch` (lib) generated 14 warnings
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.23s

Some of the variations need this cast, and I don't understand the format well enough to know how to deal with that.

@rustbot
Copy link
Collaborator

rustbot commented Jul 11, 2025

r? @folkertdev

rustbot has assigned @folkertdev.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@folkertdev folkertdev added this pull request to the merge queue Jul 11, 2025
Merged via the queue into rust-lang:master with commit 0057aa8 Jul 11, 2025
62 checks passed
@hkBst hkBst deleted the thumbv7neon-unknown-linux-gnueabihf-clippy-fixes branch July 11, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants