stdarch-gen-arm: remove lazy_static, use LazyLock instead
#1868
+21
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross35
reviewed
Jul 11, 2025
| static ref MANUAL_TESTS: String = format!( | ||
| "#[simd_test(enable = \"sve\")] | ||
| unsafe fn test_ffr() {{ | ||
| static MANUAL_TESTS: &str = "#[simd_test(enable = \"sve\")] |
There was a problem hiding this comment.
Could this just be a const?
There was a problem hiding this comment.
yeah actually. I'm normally a bit worried about const's getting inlined but this is a string and it's used just once so it should be OK.
tgross35
approved these changes
Jul 11, 2025
folkertdev
force-pushed
the
gen-arm-remove-lazy-static
branch
from
85a8395 to
f0c7fcf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.