feat: Add new --skipApiVersionCheck flag #188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmdartus
force-pushed
the
pmdartus/skip-api-version-check
branch
from
3bb271f to
fcbfdf9
Compare
trevor-bliss
approved these changes
Jan 13, 2021
There was a problem hiding this comment.
The code change itself looks good to me. Before we release this to npm, I would like to have more documentation on the implications of setting this flag though (running an out of date version of LWC framework, for example).
I can get something started there in the next couple days.
ravijayaramappa
pushed a commit
that referenced
this pull request
Jan 15, 2021
ravijayaramappa
added a commit
that referenced
this pull request
Jan 15, 2021
* feat: Add new --skipApiVersionCheck flag (#188) * Add README note about --skipApiVersionCheck flag (#190) * Add README note about --skipApiVersionCheck flag * fix typo * fix: update snapshot to match old version of yargs Co-authored-by: Pierre-Marie Dartus <[email protected]> Co-authored-by: Trevor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new advanced flag
--skipApiVersionCheck. When this flag is passed, sfdx-lwc-jest will not check if thesfdx-project.jsonsourceApiVersionfield is matching with matching the expected API version.With this flag, ISV who want to avoid bumping their package API version at a different cadence than Salesforce release can keep their test runner version up-to-date.