fix: apex automock not returning a resolved promise #231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jodarove
requested review from
pmdartus,
ravijayaramappa,
ekashida and
trevor-bliss
trevor-bliss
approved these changes
Jun 24, 2021
nolanlawson
approved these changes
Jun 24, 2021
jodarove
added a commit
that referenced
this pull request
Jun 24, 2021
This was referenced Jun 29, 2021
jodarove
added a commit
that referenced
this pull request
Jun 30, 2021
…235) This reverts commit 0cc034d. This PR reverts #210, and #208 (#231 was never included in summer21 branch). They provided functionality to auto mock apex methods. **Notes:** - Test authors will need to keep implementing their own apex (+apexContinuation) methods mocks after this PR is merged. - These changes were added to the summer21 branch with #224.
jodarove
added a commit
that referenced
this pull request
Jun 30, 2021
…utomocks (#234) fixes #232 This PR reverts #231, #210, and #208. They provided functionality to auto mock apex methods. **Note:** Test authors will need to keep implementing their own apex (+apexContinuation) methods mocks after this PR is merged. * Revert "fix: apex automock should return a resolved promise (#231)" This reverts commit 544f95a. * Revert "fix: add apex stubs to the transformIgnorePatterns (#210)" This reverts commit fe8381a. * Revert "fix: automock apex methods with valid wire adapters (#208)" This reverts commit 125c689.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
fixes #230
#208 automocks apex and apexContinuation methods with the correct test wire adapter instead of those provided by the
@lwc/jest-transformer(apex, apexContinuation). However, it does not implement correctly the mocked function that is used when invoking imperatively the apex method (the correct implementation is defined here).This PR mocks the implementation of the apex method to return a resolved promise.