Skip to content

Change timestamp to ISO 8601 #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Change timestamp to ISO 8601 #109

merged 1 commit into from
Sep 15, 2023

Conversation

ninxsoft
Copy link
Contributor

@ninxsoft ninxsoft commented Sep 15, 2023

sal-submit is currently logging timestamps as asctime, a human-readable format that does not provide any timezone information out-of-the-box:

2023-09-15 12:34:56,789

Proposing to change the default logging timestamp to an ISO 8601 compatible one with the timezone offset:

2023‐09‐15T12:34:56+1000

Caveats:

  • The %z directive provides +HHMM / -HHMM style timezones offsets, omitting colons :, however this still qualifies as a valid ISO 8601 timestamp.
  • There does not seem to be a valid directive to display milliseconds - is this important?

@grahamgilbert grahamgilbert merged commit af715df into salopensource:main Sep 15, 2023
@ninxsoft ninxsoft deleted the feature-iso8601-dateformat branch September 16, 2023 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants