Skip to content

fix(discord.js-utilities)!: update the action row component type #888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 7, 2025
Merged

fix(discord.js-utilities)!: update the action row component type #888

merged 2 commits into from
May 7, 2025

Conversation

SerenModz21
Copy link
Contributor

@SerenModz21 SerenModz21 commented May 1, 2025 •
edited
Loading

Discord.js 14.19.x utilises discord-api-types #1190 of which includes a breaking change that renamed APIMessageActionRowComponent to APIComponentInMessageActionRow. Due to this, I have marked this PR as a breaking change for discord.js-utilities.

Additionally, I have removed discord-api-types and @discordjs/collection from dev deps so that the versions that discord.js installs can be used instead. This is a change that the d.js docs "subpackages" tag suggests:

discord.js includes multiple sub-packages, installing these separately can mess with internal code:

npm uninstall discord-api-types @discordjs/rest @discordjs/builders
yarn remove discord-api-types @discordjs/rest @discordjs/builders
pnpm remove discord-api-types @discordjs/rest @discordjs/builders

Fixes sapphiredev/cli#386

@SerenModz21 SerenModz21 mentioned this pull request May 5, 2025
Closed
1 task
@favna favna merged commit 3b2a6fa into sapphiredev:main May 7, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@favna favna favna approved these changes

@kyranet kyranet Awaiting requested review from kyranet kyranet is a code owner

@vladfrangu vladfrangu Awaiting requested review from vladfrangu vladfrangu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: New created project doesn't work
2 participants
@SerenModz21 @favna