Fix passing variables across compilations #367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntkme
force-pushed
the
fix-variable-across-compilation
branch
3 times, most recently
from
c708151 to
62c3e8a
Compare
ntkme
force-pushed
the
fix-variable-across-compilation
branch
2 times, most recently
from
32bce7d to
ffda07a
Compare
ntkme
force-pushed
the
fix-variable-across-compilation
branch
from
ffda07a to
9970cd2
Compare
ntkme
force-pushed
the
fix-variable-across-compilation
branch
from
9970cd2 to
b216d0a
Compare
ntkme
force-pushed
the
fix-variable-across-compilation
branch
from
b216d0a to
0c35faf
Compare
ntkme
force-pushed
the
fix-variable-across-compilation
branch
from
0c35faf to
fd2febc
Compare
nex3
approved these changes
May 5, 2025
| @@ -18,6 +18,7 @@ import {Value} from './value'; | |||
| * execute them. | |||
| */ | |||
| export class FunctionRegistry<sync extends 'sync' | 'async'> { | |||
| public readonly compileContext = Symbol(); | |||
| @@ -19,7 +19,18 @@ export class SassArgumentList extends SassList { | |||
| * part of the package's public API and should not be accessed by user code. | |||
| * It may be renamed or removed without warning in the future. | |||
| */ | |||
| readonly id: number; | |||
| readonly id: number | undefined; | |||
There was a problem hiding this comment.
Document what it means for this to be undefined.
| @@ -44,7 +44,7 @@ export class Protofier { | |||
| get accessedArgumentLists(): number[] { | |||
| return this.argumentLists | |||
| .filter(list => list.keywordsAccessed) | |||
| .map(list => list.id); | |||
| .map(list => list.id as number); | |||
There was a problem hiding this comment.
Suggested change
| .map(list => list.id as number); | |
| .map(list => list.id!); |
Comment on lines
+89
to
+91
| const list = create(proto.Value_ArgumentListSchema, { | ||
| id: value.id, | ||
| }); |
There was a problem hiding this comment.
Suggested change
| const list = create(proto.Value_ArgumentListSchema, { | |
| id: value.id, | |
| }); | |
| const list = create(proto.Value_ArgumentListSchema, {id: value.id}); |
Goodwine
reviewed
May 7, 2025
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "name": "sass-embedded", | |||
| "version": "1.87.0", | |||
| "protocol-version": "3.1.0", | |||
| "protocol-version": "3.2.0", | |||
There was a problem hiding this comment.
I believe the repo is currently in a broken state because sass/sass#4073 was submitted bumping the protocol version, and the repo expects this to match.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses sass/dart-sass#2542 for the embedded host side by porting sass-contrib/sass-embedded-host-ruby@c05a8f5...0378284.
sass/dart-sass#2544
sass/sass-spec#2053