integrations: Fix IRC <-> Zulip bridge? #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rht
reviewed
Jun 22, 2023
| # Make sure the bot is subscribed to the stream | ||
| self.check_subscription_or_die() | ||
| # Initialize IRC bot after proper connection to Zulip server has been confirmed. | ||
| irc.bot.SingleServerIRCBot.__init__(self, [(server, port)], nickname, nickname) | ||
| irc.bot.SingleServerIRCBot.__init__(self, [(server, port)], nickname, nickname, sasl_login) |
There was a problem hiding this comment.
Can you pass sasl_login as a keyword argument? See https://github.com/jaraco/irc/blob/f1bc7baaad0892ddbd1ba38491635f00237a2fd9/irc/bot.py#L158.
There was a problem hiding this comment.
I tried passing sasl_login as keyword argument and have updated the code.
But the following error occurs:
Traceback (most recent call last):
File "/home/sbansal1999/p/python-zulip-api/zulip/integrations/bridge_with_irc/irc-mirror.py", line 70, in <module>
bot.start()
File "/srv/zulip-py3-venv/lib/python3.10/site-packages/irc/bot.py", line 347, in start
self._connect()
File "/srv/zulip-py3-venv/lib/python3.10/site-packages/irc/bot.py", line 187, in _connect
self.connect(
File "/home/sbansal1999/p/python-zulip-api/zulip/integrations/bridge_with_irc/irc_mirror_backend.py", line 47, in connect
self.c = self.reactor.loop.run_until_complete(self.connection.connect(*args, **kwargs))
TypeError: AioConnection.connect() got an unexpected keyword argument 'sasl_login'
There was a problem hiding this comment.
That's because the SASL PR is possibly implemented only for the sync client. Try reverting zulip@910f83e.
There was a problem hiding this comment.
That actually doesn't make sense. The AioConnection is a subclass of ServerConnection. jaraco/irc#199 modifies ServerConnection. So the AioConnection should accept sasl_login.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.