Skip to content

Updated Eval Exercise to take input, spec was off as well #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 10, 2020
Merged

Updated Eval Exercise to take input, spec was off as well #127

merged 1 commit into from
Jul 10, 2020

Conversation

@jeremylaier
Copy link
Contributor

@jeremylaier jeremylaier commented Jul 10, 2020

Entire Eval Site is not taking input, fixed that.

One test in eval spec was not formatted correctly, flipped two of the answers and now its proper.

@jeremylaier
Copy link
Contributor Author

jeremylaier commented Jul 10, 2020 •
edited
Loading

@juanpedromoreno @scala-steward @FRosner

juanpedromoreno
juanpedromoreno approved these changes Jul 10, 2020
View reviewed changes
Copy link
Contributor

@juanpedromoreno juanpedromoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jeremylaier !

@juanpedromoreno juanpedromoreno merged commit 7461054 into scala-exercises:master Jul 10, 2020
@jeremylaier jeremylaier deleted the (FIX)EvalExercises branch July 10, 2020 17:51
@jeremylaier jeremylaier mentioned this pull request Aug 6, 2020
Closed
@jeremylaier
Copy link
Contributor Author

jeremylaier commented Aug 28, 2021

@jeremylaier I was working on Cats | Eval and I can't run any of the examples. At first I thought it was a "joke" because of Eval's memoization, but I found this page and realized it was not. I currently see the values that you changed in this request...for example, line 70 reads:

eagerEval.value shouldBe (resultList: List[Int])

Not, a blank space for me to type something in. Is it possible your changes are being overwritten by Eval?

this PR was never deployed to the site. Not sure when they last released and deployed a new version

@Jeremy-Laier Jeremy-Laier mentioned this pull request Sep 12, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juanpedromoreno juanpedromoreno juanpedromoreno approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jeremylaier @juanpedromoreno