Skip to content

Scala 2 download pages: link to version-specific notes #1775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 10, 2025

Conversation

SethTisue
Copy link
Member

@SethTisue SethTisue commented Mar 9, 2025

we've had this problem for yearrrrrrrrrs and I've always meant to fix it, and, well, today's the day

also remove the unneeded links to the archive of old release blog posts. it's distracting noise. the release notes have been on GitHub at least since 2.12.0 and we just don't care whether older versions are now a bit harder to find

also remove the unneeded links to the archive old release blog posts
@SethTisue
Copy link
Member Author

I built the site locally to verify that e.g. /download/2.13.16.html now links to https://github.com/scala/scala/releases/tag/v2.13.16 specifically instead of the more general https://github.com/scala/scala/releases

@SethTisue SethTisue requested a review from lrytz March 9, 2025 23:42
@SethTisue SethTisue merged commit f5cbbcb into scala:main Mar 10, 2025
1 check passed
@SethTisue SethTisue deleted the scala-2-release-notes-links branch March 10, 2025 18:33
@SethTisue
Copy link
Member Author

SethTisue commented Mar 10, 2025

@WojciechMazur I'm sort of guessing you'll be okay with the Scala 3 part of this, but, double-checking. The situation is a bit different in Scala 3 since (iirc) you have content in the release announcements on scala-lang.org that isn't in the GitHub release notes?

@WojciechMazur
Copy link
Contributor

Looks good to me. For the Scala 3 releases, especially new minors and it's the longer blogposts, we can add link in the GH changelog. In case of patches the scala-lang announcement can typically be the same as GH changelog, in such case there would be no need to link between them, that's the case for the last one: https://scala-lang.org/news/3.6.4/ - https://github.com/scala/scala3/releases/tag/3.6.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants