Some updates to integration tests #385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunfeng-scale
commented
Nov 17, 2023
|
|
||
|
|
||
| @pytest.mark.skipif(CIRCLECI, reason="skip on circleci since need to figure out s3 access") | ||
| @pytest.mark.skipif( |
There was a problem hiding this comment.
@saiatmakuri FYI, i don't think this sounds as an integration test. can consider checking # tokens from responses?
There was a problem hiding this comment.
yeah can skip for now. essentially want to check if every tokenizer can be made before each deploy
There was a problem hiding this comment.
it currently fails for me since initdb is not in bash container. can be fixed by adding postgres there
saiatmakuri
approved these changes
Nov 17, 2023
integration_tests/test_fine_tunes.py
Outdated
|
|
||
|
|
||
| @pytest.mark.skipif( | ||
| os.getenv("ENV") == "prod", |
There was a problem hiding this comment.
skip if == "launch" as well?maybe we can limit this to circleci for now
There was a problem hiding this comment.
training cluster is proper set up for this. i do think we want some e2e test like this.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Some updates to integration tests
Test Plan and Usage Guide
How did you validate that your PR works correctly? How do you run or demo the code? Provide enough detail so a reviewer can reasonably reproduce the testing procedure. Paste example command line invocations if applicable.