try fixing bug in batch completions #633
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmchoiboi
approved these changes
Oct 11, 2024
seanshi-scale
deleted the
seanshi/20241010-batch-completions-param-bug
branch
dmchoiboi
reviewed
Oct 11, 2024
| gpu_memory_utilization=request.max_gpu_memory_utilization or 0.9, | ||
| **parsed_configs.model_dump(exclude_none=True), | ||
| ) | ||
| default_engine_args_dict.update(engine_args_dict) |
There was a problem hiding this comment.
ah it's the duplicate gpu_memory_utilization field
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
What is this PR changing? Why is this change being made? Any caveats you'd like to highlight? Link any relevant documents, links, or screenshots here if applicable.
Test Plan and Usage Guide
Test in prod