Skip to content

Conversation

dmchoiboi
Copy link
Collaborator

Pull Request Summary

What is this PR changing? Why is this change being made? Any caveats you'd like to highlight? Link any relevant documents, links, or screenshots here if applicable.

Remove hardcoded check on model name

Test Plan and Usage Guide

How did you validate that your PR works correctly? How do you run or demo the code? Provide enough detail so a reviewer can reasonably reproduce the testing procedure. Paste example command line invocations if applicable.

@dmchoiboi dmchoiboi force-pushed the dmchoi/remove-restrictive-check branch from d38da06 to ae09632 Compare November 4, 2024 18:04
Copy link
Contributor

@seanshi-scale seanshi-scale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does model_name only become a hint for default compute settings at this point?

@dmchoiboi dmchoiboi enabled auto-merge (squash) November 4, 2024 18:23
@dmchoiboi dmchoiboi merged commit 84f31a8 into main Nov 4, 2024
7 checks passed
@dmchoiboi dmchoiboi deleted the dmchoi/remove-restrictive-check branch November 4, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants