Make cooldown period configurable #665
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunfeng-scale
changed the title
yunfeng-scale
approved these changes
Dec 9, 2024
| node-lifecycle: normal | ||
| nodeSelector: | ||
| node-lifecycle: normal | ||
| keda: |
There was a problem hiding this comment.
can you also add it to value_samples and everywhere else, otherwise please set default values
There was a problem hiding this comment.
is there a list of all files for where the update should be made? I based my logic of this PR which seems to only update one values file
There was a problem hiding this comment.
actually i think it might be fine. helm should be able to take default values from values.yaml
There was a problem hiding this comment.
ok great, will merge then. appreciate the review!
sohumh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Allow the
cooldownPeriodused in keda for autoscaling to be set as a helm value.Test Plan and Usage Guide
Ran
helm template model-engine model-engine/ -f model-engine/values_circleci.yamlto validate it gets populated as intended