-
Notifications
You must be signed in to change notification settings - Fork 37
API transform solver functions into classes #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
87 commits
Select commit
Hold shift + click to select a range
4dc9f20
transform prox newton into a solver
mathurinm d7b83cb
Merge branch 'main' of github.com:scikit-learn-contrib/skglm into sol…
mathurinm 2c9f953
WIP cd solver
PABannier 84cfaa0
try solver
PABannier 0f469b3
linter happy
PABannier 44e5b3c
intialize df
mathurinm 715f4cb
WIP generalized Linear estimator
PABannier d62e18a
WIP
PABannier 8928c1c
WIP estimators
PABannier bf8784c
CLN rest of estimators
PABannier 058d94c
lint
PABannier 8215ca7
Update skglm/estimators.py
PABannier 1b216ef
changed to _glm_fit
PABannier a847b59
Merge branch 'solver_class' of https://github.com/mathurinm/skglm int…
PABannier cc0ac81
a -> an
PABannier d92f292
refactor GramCD
PABannier fc5d488
cln estimators
PABannier 803d357
some fixes for doc
mathurinm 2fe0360
model passed to solver.solve, fit_intercept as attribute of model
mathurinm 1aeaeab
warm_start
PABannier 993b5b1
warm_start 2
PABannier 7f06be0
Merge branch 'solver_class' of https://github.com/mathurinm/skglm int…
PABannier d47f0a9
FIX tests
PABannier 92a2b80
fix more tests
PABannier b765d4d
fixed test_prox_newton
PABannier 5ff9945
fix test datafits
PABannier 1402a16
fix gram tests
PABannier 74cd022
prox newton
mathurinm 1d36882
changed signature of solver.solve
PABannier 9817dda
Merge branch 'solver_class' of https://github.com/mathurinm/skglm int…
PABannier 61f7370
solver.solve harmonized
PABannier 6c1b026
added tol to estimators (except GLE)
PABannier b373bce
fix
PABannier 214b195
test groups fixed
PABannier 840010d
fixed some other tests
PABannier 99eb5bc
added MTL solver
PABannier 8cf7be7
lint
PABannier b0c8fcb
added warm start
PABannier 486f6af
better namings of files
PABannier 831dea0
fix linting
PABannier 80a3ca0
changed to PN for defaut solver in logreg
PABannier c6326b5
fix some bugs
PABannier 5706695
Merge branch 'main' of github.com:scikit-learn-contrib/skglm into sol…
mathurinm 998fe6a
fix signature path mtl
PABannier 980c6aa
Merge branch 'solver_class' of https://github.com/mathurinm/skglm int…
PABannier 5531131
rm warm_start and fit_intercept from GLE
mathurinm 9b79388
Merge branch 'solver_class' of github.com:mathurinm/skglm into solver…
mathurinm 9e68bee
some fixes
mathurinm 8950736
fix some docstrings
mathurinm 5729aec
fix Lasso test, design is not the best
mathurinm 2c754ab
exposes attributes to estimators
PABannier 83e1034
passing test estimators
PABannier bc3421d
fixed MTL tests
PABannier f524a31
fix return_n_iter
PABannier 226bf61
added xfail for fit intercept in PN
PABannier 4c6521d
remove fit_intercept from SVC
PABannier 318d968
linter almost happy
PABannier 2e38382
tests are passing
PABannier 9b9b7f1
Update skglm/estimators.py
PABannier 67ebeba
Update skglm/estimators.py
PABannier eb3bc5d
_solver -> solver'
PABannier 95b7c93
remove solver from docstring
PABannier 2c1c13f
removed path
PABannier 2d656ae
Merge branch 'solver_class' of https://github.com/mathurinm/skglm int…
PABannier c1c6976
remove noqa
PABannier e6a035f
revert
PABannier b46521e
docs building
PABannier fd38917
docs building 2
PABannier fcfa0ea
exposed p0, tol, max_iter, etc...
PABannier 4220c1e
linter ok
PABannier 3fb5ef1
fix pydocstyle
PABannier 4220ae3
revert __init__
PABannier ddb0174
fix docstring
PABannier 115437c
l
PABannier 436de98
green?
PABannier d054b8c
ADD base solver
PABannier ec43d36
green
PABannier 43b333a
Merge branch 'solver_class' of github.com:mathurinm/skglm into solver…
mathurinm 7e9664d
Merge branch 'main' of github.com:scikit-learn-contrib/skglm into sol…
mathurinm 9e9e1e4
rename to AndersonCD solver, remove try_solver.py
mathurinm 38bf792
CLN
mathurinm 0cee34a
rename accelerated_cd.py to anderson_cd.py
mathurinm ad77737
Update skglm/solvers/prox_newton.py
mathurinm 84be3fa
exchange path and solve order in MTL
mathurinm c480523
fix bug intercept in AndersonCD
Badr-MOUFAD baf2f56
illustrative comment in gram_solver
Badr-MOUFAD ab6bab1
linter happy
Badr-MOUFAD File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.