DeprecationWarning: Using or importing the ABCs from 'collections' in Python 3.7

[JianXin-Yun]

[JianXin-Yun]

[jnothman]

I think we should aim to solve this after the next release of six. See benjaminp/six#241

[amueller]

When was that moved, i.e. will #11115 help?

[jnothman]

yes, collections.abc is in py 3.4. so ideally we will release scikit-learn 0.20 with an updated six

[amueller]

that makes sense. And maybe for 0.21 or 0.22 we can get rid of six :)

[rth]

Given the slow pace of accepting this fix in six and that a number of users seem to have migrated already by their package manager (#11320) , should we make this fix by adding something along the lines of,

try:
    import collections.abc as collections_abc # only works on python 3.3+
except ImportError:
    import collections as collections_abc

to sklearn.utils.fixes and use that? There are less than a dozen places where this is needed in scikit-learn core code base ( see sklearn-grep-collections.txt; not all from collection import .. in the list are ABC)

[jnothman]

sure. let's just do it. On 4 Jul 2018 5:47 pm, "Roman Yurchak" <notifications@github.com> wrote: Given the slow pace of accepting this fix in six and that a number of users seem to have migrated already by their package manager (#11320 <#11320>) , should we make this fix by adding something along the lines of, try: import collections.abc as collections_abc # only works on python 3.3+except ImportError: import collections as collections_abc to sklearn.utils.fixes and use that? There are less than a dozen places where this is needed in scikit-learn core code base ( see sklearn-grep-collections.txt <https://github.com/scikit-learn/scikit-learn/files/2162260/sklearn-grep-collections.txt>; not all from collection import .. in the list are ABC) — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#11121 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAEz6_6iaen5HQV5nATFDX7wcKYsgTsZks5uDHMYgaJpZM4UKaZx> .

[rth]

I started looking into it in 0a5fe7b (under https://github.com/rth/scikit-learn/tree/collections-abc-py37) -- this is not very elegant and there are are few more places where import names would need to be changed. One of the issue is that from sklearn.utils.fixes.collections_abc import .. doesn't work here. Probably fixable, but I'm not sure I should spend too much time on it.

Maybe patching the vendored version of six would be better/easier?

[jnothman]

Yeah, I've wondered about patching the vendored six. If we *need* to, we should...​