[MRG] hotfix for LinearSVR segfault on memmap #11133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amueller
force-pushed
the
linearsvr_y_writeable
branch
from
58a43e4 to
b4e925a
Compare
amueller
changed the title
Member
|
Is this tested |
Member
It solves the segfault because it trigger a copy of |
Member
|
I am +1 to solve merge this. |
Member
|
@jnothman the existing tests in master would cause a segfault but only on specific machines (like @glemaitre's) but not on others and not on travis or appveyor. |
Member
|
Can confirm this fixed #10667 for me; thank you! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hotfix for #11131.
Not sure if we care about doing this one better. If anyone wants to recompile with debug symbols and chase this down, be my guest.