Skip to content
This repository was archived by the owner on Aug 20, 2024. It is now read-only.

Conversation

@lagru
Copy link

@lagru lagru commented Jun 27, 2024

Addresses a few errors when executing the notebooks. I also took the liberty to use a more sensible and consistent numbering of parts and files.

@lagru lagru marked this pull request as ready for review July 4, 2024 11:19
@lagru
Copy link
Author

lagru commented Jul 4, 2024

Ready to merge. The reported failures when building

tutorial/03_segmentation_and_measuring.md: WARNING: Executing notebook failed: CellExecutionError [mystnb.exec]
tutorial/03_segmentation_and_measuring.md: WARNING: Notebook exception traceback saved in: tutorial/_build/html/reports/03_segmentation_and_measuring.err.log [mystnb.exec]
tutorial/03_segmentation_and_measuring.md:23: ERROR: Document orsection may not begin with a transition

are due to missing points that are intended to be picked by hand.

@lagru lagru requested review from JoOkuma and stefanv July 4, 2024 11:21
@JoOkuma
Copy link
Member

JoOkuma commented Jul 4, 2024

today is a holiday here, I'll take a look at it tomorrow, @lagru

The instructors for this workshop are
- Jordão Bragantini
- Erick Martins Ratamero
- Stefan van der Walt
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Swap Lars and Stéfan, so Lars appears first.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought to list them in speaking order. But I don't mind switching them around.

@JoOkuma
Copy link
Member

JoOkuma commented Jul 5, 2024

@lagru, the jupyters worked and everything seems correct, except it took me a minute or two to be able to load the .md as a jupyter notebook.
I didn't know how that worked and I had to right click it and select the Notebook option. Otherwise it was loaded as plain markdown.

It may be worth updating the "Running the notebooks" section on install_dependencies.md

@lagru lagru merged commit 79c8821 into scipy-2024-image-analysis:main Jul 6, 2024
@lagru
Copy link
Author

lagru commented Jul 6, 2024

Thanks @JoOkuma. That's a good point about needing to right-click in jupyter lab. In think that's a limitation of jupytext. Jupyter notebook opens these fine. Would you like to add a comment? :)

@lagru lagru deleted the structure-n-fixes branch July 6, 2024 06:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants