Skip to content

Configuration class #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 29, 2023
Merged

Configuration class #248

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
647df94
Config class
elacuesta Sep 9, 2023
19e2d40
Merge branch 'main' into configuration-class
elacuesta Nov 29, 2023
0cd5df6
Do not delete context kwargs after init
elacuesta Nov 29, 2023
001ab00
Fix attribute path
elacuesta Nov 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix attribute path
  • Loading branch information
@elacuesta
elacuesta committed Nov 29, 2023
commit 001ab0073c6cc1fd48dd395e729a593d168969c0
4 changes: 2 additions & 2 deletions scrapy_playwright/handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -455,9 +455,9 @@ async def _handle_download(dwnld: Download) -> None:
response = await page.goto(url=request.url, **page_goto_kwargs)
except PlaywrightError as err:
if not (
self.browser_type_name in ("firefox", "webkit")
self.config.browser_type_name in ("firefox", "webkit")
and "Download is starting" in err.message
or self.browser_type_name == "chromium"
or self.config.browser_type_name == "chromium"
and "net::ERR_ABORTED" in err.message
):
raise
Expand Down