Skip to content

Retry to create page on browser crash #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 23, 2024
Merged

Retry to create page on browser crash #305

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
664bd16
Retry to create page on browser crash
elacuesta Jul 16, 2024
b85ccf0
Add psutil to pylint tox env
elacuesta Jul 16, 2024
2546b2b
Merge remote-tracking branch 'origin/main' into retry-creating-page-o…
elacuesta Jul 16, 2024
e721ace
Skip browser crash tests on Windows
elacuesta Jul 16, 2024
a1d12b0
Test browser crash only in Linux
elacuesta Jul 18, 2024
5939d6f
Revert "Test browser crash only in Linux"
elacuesta Jul 23, 2024
85e005a
Update browser crash test for macOS
elacuesta Jul 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update browser crash test for macOS
  • Loading branch information
@elacuesta
elacuesta committed Jul 23, 2024
commit 85e005af359f9017d1dabe682946b7af7c861ed0
2 changes: 1 addition & 1 deletion tests/tests_asyncio/test_browser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ def inject_fixtures(self, caplog):
@staticmethod
def kill_chrome():
for proc in psutil.process_iter(["pid", "name"]):
if proc.info["name"] == "chrome":
if proc.info["name"].lower() in ("chrome", "chromium"):
os.kill(proc.info["pid"], signal.SIGKILL)

@allow_windows
Expand Down