Replace platform with bowser for browser detection #1991
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisgarrity
reviewed
May 6, 2018
src/lib/supported-browser.js
Outdated
| platform.name === 'Opera' || | ||
| platform.name === 'Opera Mini' || | ||
| platform.name === 'Silk') { | ||
| if (bowser.name === 'IE' || |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
added 2 commits
May 15, 2018 09:54
bowser correctly detects Chrome Headless as Chrome, is already used by scratchr2, and is more actively maintained than platform.
Also, fix detection of IE so it works. Apparently bowser.name !== 'IE' on IE with bowser. bowser.msie works though.
chrisgarrity
approved these changes
May 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
bowserpackage correctly detects Chrome Headless as Chrome, is already used by scratchr2, and is more actively maintained thanplatform.