Skip to content

Make costume, sound and sprite tiles draggable. #2130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 24, 2018

Conversation

paulkaplan
Copy link
Contributor

First step towards share-able, backpack-able costumes sounds and sprites.

Adds the ability to drag the sprite selector item, which is the component shared between sprite tiles, costume tiles and sound tiles. A custom drag layer is used for positioning the dragging asset, which uses its image to drag.

Mid-drag:
image

Doesn't do anything with dropping... yet.

Browser Coverage

Check the OS/browser combinations tested (At least 2)

Mac

  • Chrome
  • Firefox
  • Safari

Windows

  • Chrome
  • Firefox
  • Edge

Chromebook

  • Chrome

iPad

  • Safari

Android Tablet

  • Chrome

@ericrosenbaum
Copy link
Contributor

ericrosenbaum commented May 23, 2018

This is amazing! I noticed a couple things:

  • I can't drag a blank costume, or a sprite currently showing a blank costume (or at least, the dragged item was invisible). We should probably handle at least the sprite case. Not sure what it should look like while dragging- maybe just an empty box.
  • Slightly weird behavior if the sprite is animating (e.g. forever [next costume]) while being dragged- it updates the dragged thumbnail only during drag moves.

updates:

  • Dragging a blank costume or sprite also does not work in 2.0, so no big deal there.
  • Animation while dragging is not necessarily a bug?

@towerofnix
Copy link
Contributor

First step towards share-able, backpack-able costumes sounds and sprites.

🎉

Also progress towards being able to rearrange the order of sprites and assets! (#225, #1509)

Copy link
Contributor

@ericrosenbaum ericrosenbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG!

@paulkaplan paulkaplan merged commit daf9af1 into scratchfoundation:develop May 24, 2018
@paulkaplan paulkaplan deleted the draggable-assets branch May 24, 2018 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants