Show a coming-soon backpack #2133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@paulkaplan - Everything looks good to me. |
|
@paulkaplan As we discussed offline I think this looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another small step toward the backpack! The bottom bar with coming soon.
@carljbowman I want to make sure the colors on this are right.
@thisandagain @rschamp I want to make sure I understand what we want in the stand-alone preview build. This PR allows the backpack visibility to be controlled via a prop (to make it easier to remove for offline build, etc.) but I did enable it for the standalone preview build. Is that what we want to do? Or did we want to hide it completely from preview?