Fix toolbox refreshing for new variables after switching tabs #2146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnarf
reviewed
May 24, 2018
| @@ -125,6 +125,8 @@ class Blocks extends React.Component { | |||
| if (this.props.isVisible) { // Scripts tab | |||
| this.workspace.setVisible(true); | |||
| this.props.vm.refreshWorkspace(); | |||
| // Re-enable toolbox refreshes without causing one. See #updateToolbox for more info. | |||
| this.workspace.toolboxRefreshEnabled_ = true; | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
What Github issue does this resolve (please include link)?
Fixes #2120
Proposed Changes
Describe what this Pull Request does
re-enable toolbox refreshing, the way we do after doing a real toolbox refresh, after the blocks tab is re-shown after being hidden.
The full workspace refresh which is done the line before causes refreshing to be disabled. See the comments on line 148-150 for more info.
Reason for Changes
Explain why these changes should be made
Toolbox refreshing was not happening when it needed to after switching tabs.
Test Coverage
Please show how you have added tests to cover your changes
Repro the test case in the lined issue.
Browser Coverage
Check the OS/browser combinations tested (At least 2)
not browser related.
/cc @gnarf, @rschamp