Correctly apply react style object to the dom element renderer #2511
+20
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
What Github issue does this resolve (please include link)?
Proposed Changes
Describe what this Pull Request does
Use the
to-style
module to correctly translate the style object to a style string in the DOMElementRenderer.Reason for Changes
Explain why these changes should be made
So that the width/height can be applied to the canvas as CSS, since the width/height attributes are managed by the renderer.
I also removed the
shrink={0}
property, since it isn't doing anything.Test Coverage
Please show how you have added tests to cover your changes
Manually tested the issues linked above
Browser Coverage
Check the OS/browser combinations tested (At least 2)
Mac
Windows
Chromebook
iPad
Android Tablet