Skip to content

feat: precompile override #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 27, 2025
Merged

feat: precompile override #259

merged 4 commits into from
Jun 27, 2025

Conversation

lightsing
Copy link
Member

resolves #258

Copy link

codspeed-hq bot commented Jun 26, 2025

CodSpeed Performance Report

Merging #259 will improve performances by 11.34%

Comparing feat/precompile-override (5622b2b) with scroll (554b60b)

Summary

⚡ 1 improvements
✅ 76 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
hash builder[init size 10000 | update size 100 | num updates 1] 10.3 ms 9.2 ms +11.34%

@lightsing lightsing force-pushed the feat/precompile-override branch from 8da366b to 9cbc8bf Compare June 27, 2025 03:51
greged93
greged93 previously approved these changes Jun 27, 2025
Copy link
Collaborator

@greged93 greged93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@greged93
Copy link
Collaborator

Just have fmt failing, feel free to merge once fixed

@lightsing lightsing marked this pull request as ready for review June 27, 2025 06:42
@lightsing lightsing requested a review from greged93 June 27, 2025 06:48
@lispc lispc merged commit 48129ee into scroll Jun 27, 2025
44 checks passed
@lispc lispc deleted the feat/precompile-override branch June 27, 2025 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose EvmFactory as a generic parameter of ScrollEvmConfig
4 participants