Make make test-unit to fail when go test fails
#541
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the having `| tee` it's exit status is overriden and it is not failing. Solution is to pick up execution status from PIPESTATUS[0] and pass it down to exit at the end.
dkropachev
force-pushed
the
dk/make-unit-test-fail-when-test-fails
branch
from
566561a to
5bcdb9b
Compare
sylwiaszunejko
approved these changes
Sep 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the having
| teeit's exit status is overriden and it is not failing.Solution is to pick up execution status from PIPESTATUS[0] and pass it down to exit at the end.