Migrate consent integration tests to playwright from webdriver.io - LIBRARIES-2546 #1279
Conversation
…-vanilla-opt-in.test.ts and Removed all WebDriver.IO Test Cases
|
…-vanilla-opt-in.test.ts and Removed all WebDriver.IO Test Cases
packages/consent/consent-tools-integration-tests/src/page-objects/base-page.ts
Show resolved
Hide resolved
| }) | ||
| .addActionDestinationSettings( | ||
| { | ||
| private async mockCDNSettingsAPI() { |
There was a problem hiding this comment.
Can we still use CDNSettingsBuilder? The point is that it also updates remotePlugins correctly, which is important, and it’s an important helper to decouple our tests IMO
There was a problem hiding this comment.
I have verified it again that the endpoint "https://cdn.segment.com/v1/projects/foo/settings" is returning 200 OK and there is no error or warning in the Playwright Inspector console as well.
There was a problem hiding this comment.
Maybe not following -- great that it works, but is it a problem to use CDNSettingsBuilder instead like we were before?
packages/consent/consent-tools-integration-tests/src/tests/consent-tools-vanilla-opt-in.test.ts
Show resolved
Hide resolved
packages/consent/consent-tools-integration-tests/playwright.config.ts
Outdated
Show resolved
Hide resolved
packages/consent/consent-tools-integration-tests/playwright.config.ts
Outdated
Show resolved
Hide resolved
| await this.clearStorage() | ||
| } | ||
|
|
||
| getAllTrackingEvents(): any[] { |
There was a problem hiding this comment.
Can we use SegmentEvent[] rather than any, like we were before? Ditto anywhere else 'any' is used
There was a problem hiding this comment.
I have updated segmentTrackingApiReqs: SegmentEvent[] = [] but had to use fetchIntegrationReqs: CoreExtraContext[] = [] because of a linter error in the private async mockNextIntegrationsAPI() {...} at the line this.fetchIntegrationReqs.push({ url: request.url() }). The Error says: 'url' does not exist in type 'SegmentEvent'.
The only interface where url is available is [CoreExtraContext](https://github.com/segmentio/analytics-next/blob/master/packages/core/src/events/interfaces.ts). Being the only interface fitting in this scenario I assume it is fine to use it. What do you think?
| "playwright-test:headed": "playwright test --headed", | ||
| "playwright-test:debug": "playwright test --debug", | ||
| "serve": "http-server public -p 4567", | ||
| "server": "http-server --port 5432", |
There was a problem hiding this comment.
why have serve and server? can we just use one -- I prefer "serve" just because that's the name we use in signals-integration-tests?
There was a problem hiding this comment.
I think I forgot to remove the server. Thanks for pointing that out.
| @@ -10,13 +10,20 @@ | |||
| "lint": "yarn concurrently 'yarn:eslint .' 'yarn:tsc --noEmit'", | |||
There was a problem hiding this comment.
- Can we remove all the old wdio dependencies?
- Can we update/commit the yarn.lock? (CI is failing)
There was a problem hiding this comment.
CI is still failing after pushing yarn.lock. I will look into it separately once all the test cases have been migrated.
neelkanth-kaushik
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1279 +/- ##
=======================================
Coverage 84.02% 84.02%
=======================================
Files 224 224
Lines 5921 5921
Branches 1351 1351
=======================================
Hits 4975 4975
Misses 946 946
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Work In Progress : One Trust Test Case pending
consent-tools-vanilla-opt-in.test.tsandconsent-tools-vanilla-opt-out.test.tspackages/consent/consent-tools-integration-tests/src/testsTo execute the tests, run either of the following commands from the root directory of monorepo
Headless:
analytics-next % yarn workspace @internal/consent-tools-integration-tests test:intHeadfull:
analytics-next % yarn workspace @internal/consent-tools-integration-tests test:int-debug