-
Notifications
You must be signed in to change notification settings - Fork 148
Add signals strategy configuration for customers with restrictive CSPs #1284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 098319b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1284 +/- ##
==========================================
- Coverage 83.84% 82.66% -1.18%
==========================================
Files 223 224 +1
Lines 5906 6001 +95
Branches 1346 1359 +13
==========================================
+ Hits 4952 4961 +9
- Misses 954 1040 +86
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Background
This fixes CSP errors:
unsafe-inline
andunsafe-eval
without requiring customers to add these to their CSP directive. These occur because, ironically, the default safe strategy of injecting js as a string into an iframe-web-worker and evaluating is not allowed because it's dynamic, so this setting essentially removes the sandbox.The iframe sandbox is mainly needed for "vanilla" function scenarios where people can introduce infinite loops, etc -- not UI-driven auto-instrumentation scenarios, so global is probably going to become the default.
There is a feature called
Shadow Realms
that is coming to JS, that one day we will be able to use without upsetting CSPs.TLDR
The following CSP:
Produces the following error:
