Little More Gas Optimization #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @DevABDee , thank you for this PR! Could you also run |
|
I actually did that but don't know why this bot is still failing. Anyway, I think this time it's much better as it's not touching any other line 😁 |
cedoor
approved these changes
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Even tho,
uncheckedin solidity is an old method to stay safe from over/underflow Maths. But still, this method isn't useless, It helps us to save a little bit of Gas :)Related Issue
N/A
Does this introduce a breaking change?
Other information
For more info check this: https://ethereum.stackexchange.com/questions/113221/what-is-the-purpose-of-unchecked-in-solidity
Before:
After:
Thanks,
AB Dee.
P.S All the tests are passing (some tests are not passing, not because of these changes)